Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo Federation 2.0 support #153

Open
daemonsy opened this issue Jan 25, 2022 · 6 comments
Open

Apollo Federation 2.0 support #153

daemonsy opened this issue Jan 25, 2022 · 6 comments

Comments

@daemonsy
Copy link
Contributor

No description provided.

@col
Copy link
Contributor

col commented Apr 25, 2022

Is anyone working on adding support for Apollo Federation 2.0?

If not, any thoughts or discussions on how this would be approached?

@col
Copy link
Contributor

col commented Apr 26, 2022

Draft PR that adds support for @shareable and @inaccessible directives. #196

@col
Copy link
Contributor

col commented Apr 27, 2022

Updated the PR to include @override as well. #196

These changes were surprisingly straight forward but I'm not sure if I'm missing something.

Do you think we need to warn people if they try to use a v2 directive when running a v1 gateway? I'd be happy to support something like this but we don't currently have any indication of which version they are running.

@col
Copy link
Contributor

col commented Aug 16, 2022

@daemonsy You can probably close this issue now.

@geshwho
Copy link
Collaborator

geshwho commented Aug 16, 2022

@daemonsy You can probably close this now issue now.

I don't think we're quite spec complete yet, so it may make sense to keep this open (at least until we feel okay removing the beta tag for federation 2 support).

@dariuszkuc
Copy link

dariuszkuc commented Mar 12, 2023

As of v3.5.0 all federation directives except for @composeDirective (#228) are supported by this lib. Should this be closed?

Latest compatibility results -> apollographql/apollo-federation-subgraph-compatibility#402 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants