Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent treatment for strings and symbols in field references #173

Open
geshwho opened this issue Feb 3, 2022 · 0 comments
Open

Consistent treatment for strings and symbols in field references #173

geshwho opened this issue Feb 3, 2022 · 0 comments

Comments

@geshwho
Copy link
Collaborator

geshwho commented Feb 3, 2022

#105 introduced new behavior that allows us to specify fields as symbols and automatically have the camelcased (e.g. :product_id becomes productId). In order to keep the change backwards compatible, the behavior of Strings remains unchanged. This means that there is inconsistent behavior between strings and symbols.

It would be great it, instead, we also camelize string input and give a global configuration option to either disable camelcase. This behavior would also be more inline with how graphql-ruby behaves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant