Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing improvements #29

Open
1 of 2 tasks
lennyburdette opened this issue Sep 25, 2019 · 2 comments
Open
1 of 2 tasks

Tracing improvements #29

lennyburdette opened this issue Sep 25, 2019 · 2 comments

Comments

@lennyburdette
Copy link
Contributor

lennyburdette commented Sep 25, 2019

Tracking some feedback from Apollo on the java implementation that's also relevant to this implementation.

  • Use Base64.strict_encode64

    This leaves out newlines in the middle which aren't particularly helpful when encoded in a JSON string, and causes Node to have to use a slightly slower decode implementation.

  • Capture parse and validation errors and attach them to the root node
@noaelad
Copy link

noaelad commented Oct 4, 2019

Adding some color on the second list item:

When following the current Readme instructions and enabling tracing, there are a couple of cases that result in the following error being raised, such as an invalid or unparsable query.

raise StandardError.new, 'Apollo Federation Tracing not installed. \

The error reads "... Add use ApollFederation::Tracing to your schema.", but this is not the root cause of the failure, rather it is the fact that trace[:start_time] isn't available because the query didn't execute fully. I'd ideally like to only raise that error if ApollFederation::Tracing isn't in the schema's tracers.

@prikha
Copy link
Contributor

prikha commented Oct 23, 2019

@noaelad @lennyburdette would you mind adding your setup of distributed tracing to the example, since for me even if the query is running well without it, with it I either have an error you mentioned or no tracing payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants