Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate automatically non-versioned source packages to the release assets #4907

Open
brtnfld opened this issue Oct 1, 2024 · 3 comments
Open
Labels
Component - Misc Anything else (CODEOWNERS, etc.) Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality

Comments

@brtnfld
Copy link
Contributor

brtnfld commented Oct 1, 2024

The release procedure should automatically generate copies of the hdf5-x.x.x.tar.gz and hdf5-x.x.x.zip to hdf5.tar.gz and hdf5.zip. For 1.14.5, this had to be done manually, the same as for the 1.14.4 release.

@brtnfld brtnfld added Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality Component - Misc Anything else (CODEOWNERS, etc.) labels Oct 1, 2024
@brtnfld brtnfld changed the title Generate automatically non-versioned source pachages to the release assets Generate automatically non-versioned source packages to the release assets Oct 1, 2024
@byrnHDF
Copy link
Contributor

byrnHDF commented Oct 2, 2024

Snapshots should have the non-versioned files but I disagree that a release should have them - a release is version specific since it is a specific tag.

@brtnfld
Copy link
Contributor Author

brtnfld commented Oct 2, 2024

This only concerns an additional name package that does not include the version number. The contents themselves are self-evident about the library's version. My understanding was that we agreed to do this back in 1.14.4. Some CIs I have were changed to always point to the latest release, and 1.14.5 broke it before adding the files manually.

@byrnHDF
Copy link
Contributor

byrnHDF commented Oct 2, 2024

My recollection was that it was only for snapshots, but that seems irrelevant since snapshot file are always the same; snapshot-1.14. But then again, I guess if you get to the location through latest then you don't have the version info.
The CI was changed because the copy step failed except for snapshots. You can easily add the two files, now but I will need to debug the CI for release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Misc Anything else (CODEOWNERS, etc.) Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Development

No branches or pull requests

2 participants