Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all synchronisation functionalities into an extensions module, so to be optional #583

Open
1 task done
Mec-iS opened this issue Jun 11, 2021 · 2 comments
Open
1 task done

Comments

@Mec-iS
Copy link
Contributor

Mec-iS commented Jun 11, 2021

I'm submitting a

  • feature request.

Current Behaviour:

Socket functionalities automatically run when hydrus is started so it is ready for connections from the agent. Socket is readyed and all the helpers implement a synchronisation call on the socket to communicate with an agent.

Expected Behaviour:

  • hydrus should be started as "stand-alone" by default, support for the sync mechanism should be explicitly set to be available.
  • Optimally synchornisation should be packaged in an external library to be installed as pip install hydrus-agent-sync.
  • To achieve this decoupling, we should have a config variable to be set USE_AGENT_SYNC=false/true if hydrus-agent-sync is installed
  • also all the calls to socketio in the handlers should be factorised out in hydrus-agent-sync and called only if the synchronisation is on.
@Mec-iS Mec-iS changed the title Move all synchronisation functionalities into an extensions module and decorators, so to be optional Move all synchronisation functionalities into an extensions module, so to be optional Jun 11, 2021
@sameshl
Copy link
Member

sameshl commented Jun 11, 2021

Great, that you created this issue @Mec-iS. This decoupling was really needed in hydrus.

@chrizandr
Copy link
Member

I agree, we want hydrus to be able to work without sync as well. Agent works right now without sync, this could be added here in a similar way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants