Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified Chinese translation for 2020 Performance chapter #1761

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Simplified Chinese translation for 2020 Performance chapter #1761

merged 1 commit into from
Dec 15, 2020

Conversation

Zuckjet
Copy link
Contributor

@Zuckjet Zuckjet commented Dec 14, 2020 •
edited by tunetheweb
Loading

Makes progress on #1067

tunetheweb
tunetheweb requested changes Dec 14, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me!

Some comments from a quick look over it.

src/content/zh-CN/2020/performance.md Show resolved Hide resolved
src/content/zh-CN/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-CN/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-CN/2020/performance.md Outdated Show resolved Hide resolved
@tunetheweb tunetheweb added the translation world wide web label Dec 14, 2020
@tunetheweb tunetheweb added this to the 2020 Content Translation milestone Dec 14, 2020
@tunetheweb tunetheweb mentioned this pull request Dec 14, 2020
Open
@tunetheweb tunetheweb requested review from chengxicn and removed request for rviscomi December 14, 2020 13:07
@Zuckjet Zuckjet force-pushed the performance branch 2 times, most recently from aef53a6 to 80eae72 Compare December 14, 2020 13:31
tunetheweb
tunetheweb requested changes Dec 14, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing some line differences with the original English. We like to keep these the same so easier for non-Chinese speakers to make little corrections (e.g. update an incorrect link).

src/content/zh-CN/2020/performance.md Show resolved Hide resolved
src/content/zh-CN/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-CN/2020/performance.md Show resolved Hide resolved
src/content/zh-CN/2020/performance.md Show resolved Hide resolved
src/content/zh-CN/2020/performance.md Show resolved Hide resolved
src/content/zh-CN/2020/performance.md Show resolved Hide resolved
@Zuckjet Zuckjet force-pushed the performance branch 2 times, most recently from 5b0e936 to 884659a Compare December 14, 2020 14:13
tunetheweb
tunetheweb requested changes Dec 14, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing some line differences. Could you compare to latest English and make sure they are inline?

src/content/zh-CN/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-CN/2020/performance.md Outdated Show resolved Hide resolved
chengxicn
chengxicn reviewed Dec 15, 2020
View reviewed changes
Copy link
Contributor

@chengxicn chengxicn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some translation suggestions

src/content/zh-CN/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-CN/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-CN/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-CN/2020/performance.md Outdated Show resolved Hide resolved
@Zuckjet Zuckjet force-pushed the performance branch 2 times, most recently from 2a79e44 to 7953e2e Compare December 15, 2020 12:12
@Zuckjet
Copy link
Contributor Author

Zuckjet commented Dec 15, 2020

Still seeing some line differences. Could you compare to latest English and make sure they are inline?

fixed and did a quick compared

tunetheweb
tunetheweb requested changes Dec 15, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more changes and then we're good to merge from my side

src/content/zh-CN/2020/performance.md Outdated
Comment on lines 213 to 214


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two lines when should be just one:

Suggested change

src/content/zh-CN/2020/performance.md Show resolved Hide resolved
@tunetheweb tunetheweb changed the title translation: add simplified chinese translation for performance chapter Simplified Chinese translation for 2020 Performance chapter Dec 15, 2020
@Zuckjet
Copy link
Contributor Author

Zuckjet commented Dec 15, 2020

Two more changes and then we're good to merge from my side

I don't know why my editor add so many empty line, but any way, fixed.

tunetheweb
tunetheweb approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my side. We good to merge?

@tunetheweb tunetheweb merged commit 1c6b5ca into HTTPArchive:main Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxicn chengxicn chengxicn left review comments

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees
No one assigned
Labels
translation world wide web
Projects
None yet
Milestone
2020 Content Translation
Development

Successfully merging this pull request may close these issues.
3 participants
@Zuckjet @tunetheweb @chengxicn