Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of javascript chapter to Japanese #3310

Merged

Conversation

ksakae1216
Copy link
Contributor

Please review for me.
Part of #586

I coluld not find ../2021/javascript/#async-and-defer on line 210

I've also updated src/content/en/2022/javascript.md
Please confirm it too.

@ksakae1216 ksakae1216 added the translation world wide web label Dec 17, 2022
@ksakae1216 ksakae1216 force-pushed the 2022-javascript-japanese-translation branch 5 times, most recently from e04278b to b28f6a4 Compare December 17, 2022 05:52
@ksakae1216 ksakae1216 force-pushed the 2022-javascript-japanese-translation branch from b28f6a4 to 0011fd0 Compare December 17, 2022 06:05
@ksakae1216 ksakae1216 requested review from tunetheweb and a team December 17, 2022 06:22
@tunetheweb
Copy link
Member

tunetheweb commented Dec 17, 2022

I coluld not find ../2021/javascript/#async-and-defer on line 210

This should be ../2021/javascript#async-and-defer (without the final slash) for English and ../2021/javascript#asyncとdefer for Japanese.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Did some minor tweaks (FYI for the Mozilla links we are no longer including the language as Mozilla redirects as needs be so saves us some effort).

Two small questions and then can merge and release!

src/content/ja/2022/javascript.md Outdated Show resolved Hide resolved
src/content/ja/2022/javascript.md Outdated Show resolved Hide resolved
@ksakae1216
Copy link
Contributor Author

@tunetheweb I fixed. Please review.

@tunetheweb tunetheweb merged commit c4c1c7b into HTTPArchive:main Dec 19, 2022
@ksakae1216 ksakae1216 deleted the 2022-javascript-japanese-translation branch December 22, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants