Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump treosh/lighthouse-ci-action from 11.4.0 to 12.1.0 #3693

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/predeploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Setup Node.js for use with actions
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '20'
- name: Set up Python 3.8
uses: actions/[email protected]
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/production-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Set the list of URLs for Lighthouse to check
run: ./src/tools/scripts/set_lighthouse_urls.sh -p
- name: Audit URLs using Lighthouse
uses: treosh/lighthouse-ci-action@11.4.0
uses: treosh/lighthouse-ci-action@12.1.0
id: LHCIAction
with:
# For prod, we simply check for 100% in Accessibility, Best Practices and SEO
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-template-changes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Setup Node.js for use with actions
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '20'
- name: Test Template Changes
run: ./src/tools/scripts/test_template_changes.sh
- name: 'Comment PR'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test_website.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Setup Node.js for use with actions
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '20'
- name: Set up Python 3.8
uses: actions/[email protected]
with:
Expand All @@ -53,7 +53,7 @@ jobs:
COMMIT_SHA: ${{ github.sha }}
run: ./src/tools/scripts/set_lighthouse_urls.sh
- name: Audit URLs using Lighthouse
uses: treosh/lighthouse-ci-action@11.4.0
uses: treosh/lighthouse-ci-action@12.1.0
id: LHCIAction
with:
# For dev, turn off all timing perf audits (too unreliable) and a few others that don't work on dev
Expand Down
2 changes: 1 addition & 1 deletion src/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ An `.editorconfig` file exists for those using [EditorConfig](https://editorconf

Make sure you run the following commands from within the `src` directory by executing `cd src` first.

Make sure Python (3.8 or above), pip and NodeJS (v16 or above) are installed on your machine.
Make sure Python (3.8 or above), pip and NodeJS (v20 or above) are installed on your machine.

1. If you don't have virtualenv, install it using pip.

Expand Down