Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-draft option abundance file #83

Closed
BeckyGenomics opened this issue Jan 17, 2019 · 8 comments
Closed

-draft option abundance file #83

BeckyGenomics opened this issue Jan 17, 2019 · 8 comments

Comments

@BeckyGenomics
Copy link

Hello, firstly I would like to thank you for creating InsilicoSeq!

Secondly, I am using multi-config draft genomes to generate a simulated metagenome.

I was wondering if there is any option to use an abundance file with draft genomes? Just as there is with the -genomes flag? Does it also default to lognormal abundance if not specified?

Many thanks,
Becky

@HadrienG
Copy link
Owner

HadrienG commented Jan 18, 2019

Hi!

--draft is not currently compatible with abundance files and default to log-normal abundance.
There'd be no technical difficulty in implementing abundance files for draft genomes, but I'm still unsure what the best design would be.

For whole genomes (with the --genomes option the abundance files has to contain the ID of the sequence in the fasta file, which is not possible for drafts since we have more than one sequence per file that need to have the same abundance.

What I could imagine is that the abundance file would accept a file name for draft genomes. As an example:

genome_a 0.1
genome_b 0.4
path/to/draft_a.fasta 0.2
path/to/draft_b.fasta 0.3

But as I said I haven't quite made up my mind yet. As a user do you think you'd be fine with mixing genome IDs and paths in the abundance file?

Best,
Hadrien

@HadrienG HadrienG added the on hold good idea, might happen in the future label Apr 3, 2019
@bioinfoMMS
Copy link

Hi Hadrien,
Thank you for this great tool! I also would like to be able to specify abundances for draft genomes. As a user, I would be fine mixing genome IDs/names with file names (as long as it was clear in the documentation that this is what one needs to do).
Thanks,
Maddy

@novitch
Copy link

novitch commented Sep 19, 2019

Hi Adrien,
In order to show you that it can be interesting, I was looking for the same option. No problem to mix pathway for draft and genomeID.

Thanks for your tools,
Cheers,
Alban.

@HadrienG
Copy link
Owner

Thanks for the feedback folks. I'll look into if for the next minor release.

@apcamargo
Copy link

Given that the amount of fragmented genomes is increasing really fast due to the popularization of MAGs, I think this feature would be really useful!

Mixing genome IDs and paths seems to be a good solution. I don't see a problem with it.

@HadrienG
Copy link
Owner

HadrienG commented Jun 7, 2020

Planning this for 1.5.0, which should be out before the end of June :)

EDIT: better late than never, but 1.5.0 is out

@novitch
Copy link

novitch commented Aug 13, 2020

:), Thanks, will use it on my next benchmark !

@apcamargo
Copy link

That's great! Thanks @HadrienG!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants