Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Processing clears image faults (gen_metadata) #263

Closed
aiscribbles opened this issue May 28, 2024 · 3 comments
Closed

Post Processing clears image faults (gen_metadata) #263

aiscribbles opened this issue May 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@aiscribbles
Copy link
Contributor

single_image_faults = []

This line sets the single_image_faults to an empty list. And then later that is returned as the overall list of faults for that result. But the original list of faults (stored in the variable faults) needs to be merged with that.

I would recommend replacing the referenced line with the following, or something to this effect. Copying the previous faults list as a starting point for the single_image_faults variable.

single_image_faults = faults[:]

@aiscribbles
Copy link
Contributor Author

there's a chance i'm misunderstanding something in this bit of code. But some local testing on my part confirms that when I use post-processors, the /status/ endpoint never returns the expected gen_metadata.

@aiscribbles
Copy link
Contributor Author

Just made a pull request with this change: #295

@tazlin tazlin added the bug Something isn't working label Aug 26, 2024
@tazlin
Copy link
Member

tazlin commented Aug 26, 2024

Closed via #298. Thanks again

@tazlin tazlin closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants