Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NodeBlockSync and SyncMempoolManager for better dependency injection #1099

Open
jansegre opened this issue Jul 29, 2024 · 1 comment
Open

Refactor NodeBlockSync and SyncMempoolManager for better dependency injection #1099

jansegre opened this issue Jul 29, 2024 · 1 comment

Comments

@jansegre
Copy link
Member 

          Should we have this as an `__init__()` dependency instead of manually instantiating it here? It would be easier for unit testing

Originally posted by @glevco in #275 (comment)
@jansegre jansegre mentioned this issue Jul 29, 2024
Merged
7 tasks
@jansegre
Copy link
Member Author

jansegre commented Oct 3, 2024

Still applies, SyncMempoolManager in the sync-v2 agent, could be externally instantiated and passed down when instantiating a NodeBlockSync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Hathor Network
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jansegre