FlxAngle.rotatePoint() -> FlxPoint#rotate(), FlxAngle.getAngle() -> FlxPoint#angleBetween()

[Gama11]

This makes sense because these are functions that operate on FlxPoint. There is no reason for these to be located in a static utility class.

Also, by taking x and y as parameters separately, you end up having to pass the x and y of a point around individually, which kind of defeats the point (no pun intended).

Moving these to FlxPoint greatly reduces their function signature (rotatePoint() went from 6 parameters (one optional) to only 2 (!).

I think it makes for much more readable code. The code snippet I posted here now becomes this:

package;

import flixel.FlxG;
import flixel.FlxSprite;
import flixel.FlxState;
import flixel.math.FlxAngle;
import flixel.system.scaleModes.FixedScaleMode;
using flixel.util.FlxSpriteUtil;

class PlayState extends FlxState
{   
    var sprite = new FlxSprite();
    var pivot = new FlxSprite(200, 200);

    override public function create():Void 
    {
        FlxG.scaleMode = new FixedScaleMode();
        add(sprite.screenCenter());
        add(pivot);
    }

    override public function update():Void 
    {
        super.update();

        var spritePosition = sprite.toPoint();
        spritePosition.rotate(pivot.toPoint(), 3);
        sprite.setPosition(spritePosition.x, spritePosition.y);
    }
}

As you can see, this comboes very nicely with FlxObject#toPoint() I added here. The only thing that's bothering me a little here is that there's no way to set the position of a FlxObject via a point. Maybe we should add FlxObject#setPositionByPoint()? That strikes me as too verbose though.

[Gama11]

The other thing I'm not sure about is whether or not these functions should be inlined. I left the keyword in there for now, but they are quite lenghty, so it might not be beneficial at all.

[gamedevsam]

Definitely not a good inline candidate (loops and if statements).

[gamedevsam]

This is excellent! 👍