FlxAngle: Added angleFromFacing. FlxVelocity: DRY

[kevinresol]

Accelerate functions now take a single maxSpeed (instead of a maxSpeed separately in x/y)

[Gama11]

What's the logic behind removing the separation between x and y? Don't we lose flexbility that way?

[JoeCreates]

@Gama11 Not exactly. If you have a separate X and Y you don't have any way of limiting the scalar speed. For example, if max x and y velocity are both 1, your max speed when moving horizontally is 1, but moving diagonally 2^0.5 ≈ 1.41.

Perhaps ideally we'd have both a maxSpeed and maxVelocityX/Y?

[kevinresol]

First, it is a matter of consistency. Currently acceleration is given as scalar and maxSpeed is given as vector.
Second, functionality-wise, like what @JoeCreates mentioned, I think most users expect the speed to be capped at a scalar maxSpeed regardless of the angle of movement.

[MSGhero]

You would set the X and Y speeds to .707 if you wanted a scalar speed of 1. Out of convenience, though, I'd rather tell it a scalar speed and have it sort out the vector X and Y components. When would you ever restrict the speeds differently?

[JoeCreates]

@MSGhero You might want X and Y speed limits on a grid based game, if you wish to have moving diagonally occur as quickly as moving horizontally or vertically.

[kevinresol]

What is the point of letting the function calculate the acceleration vector based on an angle but not the same for maxSpeed?
If you have to set the maxSpeed x/y separately, I suppose you want to do the same for acceleration. (vise-versa)

[JoeCreates]

Yeah, that would be the case. It would be way overkill to have both. :P

[kevinresol]

Btw, I suggest adding a resetSpeed parameter to specify whether velocity.set(0,0) or not

[JoeCreates]

Out of interest, why did you change this to an if statement?

[kevinresol]

Because Haxe's switch statement won't let you do this:

switch(sth)
{
    case 1 + 1: 2; // error: Case expression must be a constant value or a pattern, not an arbitrary expression
}

Or I should define each inline vars before using the switch statement. e.g.

public static inline var UP_LEFT = UP | LEFT;

[mrcdk]

But, you can, it's Haxe: http://try.haxe.org/#416d9

It's called pattern guards: http://haxe.org/manual/lf-pattern-matching-guards.html

[JoeCreates]

Ah cool. Didn't know that. :)