Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch Expressions #1790

Merged
merged 2 commits into from
Mar 27, 2016
Merged

Watch Expressions #1790

merged 2 commits into from
Mar 27, 2016

Conversation

MSGhero
Copy link
Member

@MSGhero MSGhero commented Mar 26, 2016

Added watching the hscript-parsed output of an expression in the Watch window of the debug menu.

watchexpr
more watch expr

@MSGhero
Watch Expressions
65b741d 
Added watching the hscript-parsed output of an expression
@MSGhero
Copy link
Member Author

MSGhero commented Mar 26, 2016

What's up with travis? All the tests are fine, but neko is Done(1)ing when they're all done. I didn't break anything afaik.

@Gama11
Copy link
Member

Gama11 commented Mar 26, 2016

https://travis-ci.org/HaxeFlixel/flixel/jobs/118738285#L303

@Gama11 Gama11 added this to the 4.1.0 milestone Mar 26, 2016
@MSGhero
Copy link
Member Author

MSGhero commented Mar 26, 2016

https://github.com/HaxeFlixel/flixel/blob/dev/flixel/system/debug/console/ConsoleUtil.hx#L60 ?

@MSGhero
Copy link
Member Author

MSGhero commented Mar 27, 2016

I cleared all my local changes, updated flixel, downloaded the 4 changed files, and got it working fine on flash...

Edit: and windows

@Gama11
Copy link
Member

Gama11 commented Mar 27, 2016

Run haxelib run openfl build coverage flash -Dcoverage2 locally on the coverage test to repro that. The problem is that you're not checking whether hscript is included (runCommand() only exists in that case).

@MSGhero
Copy link
Member Author

MSGhero commented Mar 27, 2016

Forgot about that...

@Gama11
Copy link
Member

Gama11 commented Mar 27, 2016

Cool feature! 👍

@Gama11 Gama11 merged commit 15cacb4 into HaxeFlixel:dev Mar 27, 2016
@MSGhero MSGhero deleted the watchExpr branch August 21, 2016 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MSGhero @Gama11