Fix FlxText applyMarkup for markers with length > 1. #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Great-looking game btw. :) |
Gama11
added a commit
that referenced
this pull request
Aug 21, 2016
This makes them more dox-friendly. Also added an example for multi-character markers in applyMarkup() (see #1908). [skip ci]
Gama11
added a commit
to HaxeFlixel/flixel-demos
that referenced
this pull request
Aug 21, 2016
…kup() see HaxeFlixel/flixel#1908 Removed some odd code in update() - presuambly leftover debugging code.
|
I added an example of this to the demo: HaxeFlixel/flixel-demos@e218192 |
Aurel300
pushed a commit
to larsiusprime/haxeflixel
that referenced
this pull request
Apr 18, 2018
Aurel300
pushed a commit
to larsiusprime/haxeflixel
that referenced
this pull request
Apr 18, 2018
This makes them more dox-friendly. Also added an example for multi-character markers in applyMarkup() (see HaxeFlixel#1908). [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried using applyMarkup with some colored text tags, using multi-character markers which all start with the same character, like [red], [blue], [green]. The current implementation only looks at the first character of the marker, so each left brace matches every marker, resulting in the positions of the format ranges being off. Doing a full comparison against the marker fixes this issue.
Before:
After (correct):