FlxSound: add endTime, closes #1906 #1943
Conversation
| private function set_loopTime(value:Float):Float | ||
| { | ||
| loopTime = value; | ||
| if (_sound != null) |
There was a problem hiding this comment.
Couldn't we use the length property to avoid the null checks?
There was a problem hiding this comment.
yes, of course. i've missed this new property)
There was a problem hiding this comment.
You forgot to remove the null checks. :)
|
|
||
| private function set_loopEndTime(value:Float):Float | ||
| { | ||
| return loopEndTime = (value <= loopTime) ? length : value; |
There was a problem hiding this comment.
So, you prevent invalid loopEndTime values here... However, what these values are depends on loopTime. What happens if loopTime is set after loopEndTime?
|
I'm not sure how much is gained by having setters for Maybe it's better to just trust the user to supply correct values? That way there are no bugs caused by Flixel / bounding the values at least. |
|
yeah, i think it would be better. |
|
It's really not as simple as it looks, there's a lot of things to take into account. :) |
| */ | ||
| public function play(ForceRestart:Bool = false, StartTime:Float = 0.0):FlxSound | ||
| public function play(ForceRestart:Bool = false, StartTime:Float = 0.0, EndTime:Float = 0.0):FlxSound |
There was a problem hiding this comment.
EndTime == 0 here used to mean "set it to length", but now the behavior of set_endTime() is different.
Maybe it should be ?EndTime:Float, and if (EndTime == null), we set it to length?
Gama11
changed the title
|
Looks good now, thanks! 👍 |
See issue #1906