Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlxMouseEventManager: fix pixel-perfect overlaps with offset #1999

Merged
merged 1 commit into from
Jan 11, 2017
Merged

FlxMouseEventManager: fix pixel-perfect overlaps with offset #1999

merged 1 commit into from
Jan 11, 2017

Conversation

seraku24
Copy link
Contributor

Updated logic in FlxMouseEventManager.checkPixelPerfectOverlap to account for a non-zero offset affecting the pivot point.

@seraku24
Fix mouse events and non-zero offsets.
f3d1b65 
Updated logic in checkPixelPerfectOverlap to account for a non-zero offset affecting the pivot point.
@seraku24
Copy link
Contributor Author

@Gama11, @Beeblerox: What's the support path for issues with Travis? Near as I can tell, there appears to be an issue with the build system itself, with the haxelib install task command failing in only three of the eight jobs.

@Gama11
Copy link
Member

Gama11 commented Nov 13, 2016

That happens sometimes, I think it's an issue with the Haxelib server(s), not Travis. haxelib install task fails locally for me as well.

> haxelib install task
Downloading task-1,0,7.zip...
Download complete : 0 bytes in 0.3s (0KB/s)
Error: Eof

@Gama11
Copy link
Member

Gama11 commented Nov 13, 2016

Reported to Haxelib: HaxeFoundation/haxelib#358

@Gama11 Gama11 added the Bug label Jan 11, 2017
@Gama11 Gama11 changed the title FlxMouseEventManager: Fix mouse events and non-zero offsets. FlxMouseEventManager: fix overlaps not accounting for offset Jan 11, 2017
@Gama11 Gama11 changed the title FlxMouseEventManager: fix overlaps not accounting for offset FlxMouseEventManager: fix pixel-perfect overlaps with offset Jan 11, 2017
@Gama11 Gama11 merged commit 53e5593 into HaxeFlixel:dev Jan 11, 2017
@seraku24 seraku24 deleted the seraku24-fix-mouseevent-nonzerooffset branch April 24, 2017 15:11
Aurel300 pushed a commit to larsiusprime/haxeflixel that referenced this pull request Apr 18, 2018
@seraku24 @Aurel300
FlxMouseEventManager: fix pixel-perfect overlaps with offset (HaxeFli…
a52903b 
…xel#1999)

Updated logic in checkPixelPerfectOverlap to account for a non-zero offset affecting the pivot point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seraku24 @Gama11