FlxRandom.getObject() does not respect startIndex

[Poobslag]

• Flixel version: 4.1.1

FlxRandom.getObject does not respect the startIndex. If you specify a startIndex of 3, for example, FlxRandom.getObject will still return array items with starting indexes below 3.

---

Code snippet reproducing the issue:

package;

import flixel.FlxG;
import flixel.FlxState;
import flixel.text.FlxText;

class PlayState extends FlxState
{
	override public function create():Void
	{
		var s:String = "";
		for (i in 0...10) {
			s += FlxG.random.getObject(["x", "y", "z", "e", "e"], null, 3, 4);
		}
		add(new FlxText(0, 0, 0, "Have a d" + s + "lightful day"));
	}
}

---

Observed behavior:
"Have a dxxxyyyyxxxlightful day" is printed, FlxG.random.getObject returns random array items with index [0, 1].

Expected behavior:

"Have a deeeeeeeeeelightful day" should be printed. FlxG.random.getObject should return random array items with index [3, 4].

[Beeblerox]

i guess that the line https://github.com/HaxeFlixel/flixel/blob/dev/flixel/math/FlxRandom.hx#L292
selected = Objects[weightedPick(_arrayFloatHelper)];
should be changed to
selected = Objects[StartIndex + weightedPick(_arrayFloatHelper)];

[Beeblerox]

@Poobslag i've commited this change (f7c2991), could you check if the issue is gone?

[Poobslag]

Yeah, looks like that change fixes the issue. Thanks!

[Beeblerox]

@Poobslag can we close this issue then?

[MSGhero]

Unit test 😁