Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlxText shadow/outline issues #3235

Closed
4 tasks done
Geokureli opened this issue Aug 15, 2024 · 2 comments · Fixed by #3236
Closed
4 tasks done

FlxText shadow/outline issues #3235

Geokureli opened this issue Aug 15, 2024 · 2 comments · Fixed by #3236

Comments

@Geokureli
Copy link
Member

Geokureli commented Aug 15, 2024

Multiple issues detected with outlines:

  • shadowOffset` behaves weirdly: it defaults to (1,1) and it moves both the text and shadow when borderSize != 0
  • Shadow gets cut off when shadowOffset is outside the image: Should increase the image size. might be fixed by Fix text clipping when applying a shadow to it #3226
  • Outline gets cut off when size too big: should use a bigger image, like above
  • Increasing graphic size for border causes issues: for negative shadows or large outlines do we set offset? If we increase the graphic size will that break existing games, where specific?
@Geokureli
Copy link
Member Author

Geokureli commented Aug 15, 2024

For 1 and 2, I kinda feel like we should deprecate shadowOffset altogether and add a new border style

/**
 * A shadow that allows custom placement.
 * Note: Ignores `borderSize`
 */
SHADOW_CUSTOM(offsetX:Float, offsetY:Float);

For 3 and 4, we need to determine an image size that includes the desired outline, much like @Vortex2Oblivion did in 3226, but for all border styles

@Geokureli
Copy link
Member Author

Proposed Fix - #3236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant