Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enums where possible #998

Closed
3 tasks
Gama11 opened this issue Apr 12, 2014 · 8 comments
Closed
3 tasks

Use enums where possible #998

Gama11 opened this issue Apr 12, 2014 · 8 comments

Comments

@Gama11
Copy link
Member

Gama11 commented Apr 12, 2014

Much nicer to use.

  • FlxCamera follow styles
  • FlxCamera shake styles
  • FlxText border styles
@gamedevsam
Copy link
Contributor

Look at FlxCollisionType on how to do Int based enums. It's best to use this approach if we're checking / comparing enums every frame.

@Eiyeron
Copy link
Contributor

Eiyeron commented Apr 15, 2014

I'm trying to implement this idea. Do you have a way to test if the library edits works without overriding the haxelib?

@Gama11
Copy link
Member Author

Gama11 commented Apr 15, 2014

@Eiyeron What's your setup? I assume you have a flixel installation from haxelib and a seperate clone of the dev branch somewhere?

@Eiyeron
Copy link
Contributor

Eiyeron commented Apr 15, 2014

No , I just overrid the setup with installing my fork from git.

@Gama11
Copy link
Member Author

Gama11 commented Apr 15, 2014

Sorry, I'm not sure what your problem is then.

@Eiyeron
Copy link
Contributor

Eiyeron commented Apr 15, 2014

@Gama11 There wasn't any problems, I didn't know how to use a custom version of flixel. I have my workaround now.
I already added Enums for Camera follow/shake mode (tested with Mode. Had to change two lines to make it work : turning FlxCamera.constant into FlxCameraFollow/ShajkeMode.constant). Before going further, I'd like to have feedback from you to know if I'm doing it right, it's my first serious work for HFlixy.
Link : Fork

@Gama11
Copy link
Member Author

Gama11 commented Apr 15, 2014

Gave you some feedback. :)

@Eiyeron
Copy link
Contributor

Eiyeron commented Apr 15, 2014

Thanks, it should be clearer now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants