-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement effective_area + docs example #107
Conversation
@elizaleung830 Thanks! I've implemented the effective area (for Could you have a look if we need to adjust the resolution a bit more to converge with the numbers from the paper better? Would also be great to have graphs for the other examples they provided in the paper, should just be an extra loop as you added already the data :) After that the new example should be ready to go to the docs 🥳 |
Yes sure! I have added another graph as well as the mode transversality. However the tm_fraction doesn't seems to fit the data in paper very well, this might because of the slightly different defnition in the paper? The resolution for neff and aeff in the code look good to me. However i realised that i probably need equation 1 and 2 as I will do some stimulations on waveguide as well. Would it be possible to implment them as well? Thanks a lot! |
Hi, i have added the example sciprt and reference data from the paper, hope this help!