Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destinations quest filter too restrictive #636

Open
RubenKelevra opened this issue Sep 3, 2024 · 3 comments
Open

Destinations quest filter too restrictive #636

RubenKelevra opened this issue Sep 3, 2024 · 3 comments
Labels
enhancement New feature or request PR welcome Needs someone to implement it

Comments

@RubenKelevra
Copy link

I've noticed a couple of times now that the destination quest isn't always showing up when there are signage to map.

How to Reproduce
Currently the filter seems to be along the lines of "if there's an intersection with a road not on the white list of road types, don't show quest.

So if there's a T intersection of secondary roads, it will show up.

If the T intersection of secondary roads also got a residential road, shooting off, making it an X intersection, the quest doesn't show up.

Expected Behavior
I think the filter is too restrictive, as intersections where a major road does a turn or there's a T intersection between two major roads, there's signage to map.

It doesn't matter if there's a residential road also connected to the intersection.

So maybe the filter can be lighten up to always show the quest on intersections if there's a major road, except if the major road does go straight - and no other major road connects to this intersection?

Can we filter for degrees of turn on a road at an intersection?

Does it happen in normal StreetComplete?
No, it doesn't have the quest

Versions affected
Android 12
SCEE 58.22

@RubenKelevra RubenKelevra added the bug Something isn't working label Sep 3, 2024
@Helium314 Helium314 added enhancement New feature or request PR welcome Needs someone to implement it and removed bug Something isn't working labels Sep 28, 2024
@Helium314
Copy link
Owner

If implemented, this change must be customizable. I remember the default settings were seen as not restrictive enough by other people.
But instead of having potentially convoluted logic I'd suggest to implement a destination overlay, as was already discussed in #419

@RubenKelevra
Copy link
Author

@Helium314 was this seen as not restrictive enough in SC or SCEE? 🤔

As we got a lot of new users in SC this makes perfect sense, in SCEE a not so restrictive filter is fine I think.

I mean simply a button "nothing is posted" and we add "none" there would be fine by me. 🤷‍♂️

Btw: I noticed that the text could be slightly improved. I think it makes sense to point out that destinations should not include road refs. We have a lot "here's the way to road A1" signs in Germany, without any destination posted. And I wasn't aware that the specification is, to only add named destinations.

So I added some wrong data in the beginning :/

@Helium314
Copy link
Owner

was this seen as not restrictive enough in SC or SCEE?

In SCEE, SC doesn't even have that quest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR welcome Needs someone to implement it
Projects
None yet
Development

No branches or pull requests

2 participants