Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with API server and autotraders on restart #3306

Closed
guilherme-gm opened this issue Aug 1, 2024 · 0 comments
Closed

Issue with API server and autotraders on restart #3306

guilherme-gm opened this issue Aug 1, 2024 · 0 comments
Assignees

Comments

@guilherme-gm
Copy link
Member

guilherme-gm commented Aug 1, 2024

Creating an issue for tracking this message from Dastgir in #3304; I will look into it

 Probably unrelated to this PR, but there's one more issue wherein API server is called for autotraders on restart, and we get bunch of Account not online errors

Originally posted by @dastgirp in #3304 (comment)

Describe the bug
If you have persistent autotraders and do have one or more autotraders during server startup, you get an error for each one:

[Error]: Cant set char online. Account not logged in: 2000003

To Reproduce
Steps to reproduce the behavior:

  1. Setup a vending
  2. @autotrade
  3. Shutdown your server ( ./athena-start stop )
  4. Start the server again ( ./athena-start start )
  5. See error in console

Expected behavior
Autotraders should not cause errors during startup.

Screenshots

System specs (please complete the following information):

  • OS: 5.15.153.1-microsoft-standard-WSL2 (Unix)
  • Hercules Version v2024.07 (master from this date -- no release yet)
  • Mode: any
  • Packet version: any
  • Client type: any

Plugins used or source modifications
None

Additional context
From what I can tell so far, this comes from the fact that during autotrader loading (which happens in map-server), it will send to char which will then send to login, finally sending the list to API server which won't recognize it.

I believe we should either:

  1. Not send to API
  2. Create accounts in API if they are coming from autotrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants