Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bup: use system Python, update vendored dependencies #47592

Closed
wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Dec 7, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@iMichka iMichka added the python Python use is a significant feature of the PR or issue label Dec 7, 2019
@iMichka iMichka self-assigned this Dec 7, 2019
@fxcoudert fxcoudert mentioned this pull request Dec 7, 2019
62 tasks
@dawidd6
Copy link
Member

dawidd6 commented Dec 7, 2019

==> /usr/local/Cellar/bup/0.30_1/bin/bup init
/usr/local/Cellar/bup/0.30_1/bin/bup: /usr/local/Cellar/bup/0.30_1/libexec/bup.py: python3: bad interpreter: No such file or directory
/usr/local/Cellar/bup/0.30_1/bin/bup: line 2: /usr/local/Cellar/bup/0.30_1/libexec/bup.py: Undefined error: 0
Error: bup: failed

@dawidd6
Copy link
Member

dawidd6 commented Dec 7, 2019

Changing to:

    ENV["PYTHON"] = Formula["python3"].opt_bin/"python3"

produces this during bup init:

error: bup may crash with python versions other than 2, or eat your data

overriding this error with BUP_ALLOW_UNEXPECTED_PYTHON_VERSION spits out:

Traceback (most recent call last):
  File "/home/linuxbrew/.linuxbrew/Cellar/bup/0.30_1/lib/bup/cmd/bup-init", line 6, in <module>
    from bup import git, options, client
  File "/home/linuxbrew/.linuxbrew/Cellar/bup/0.30_1/lib/bup/bup/git.py", line 685
    raise GitError, e, sys.exc_info()[2]
                  ^
SyntaxError: invalid syntax

which concludes that bup is not adapted to python3.

@Bo98
Copy link
Member

Bo98 commented Dec 7, 2019

There is some Python 3 work in place already for 0.31. I don't know if it'll be ready before the end of the year though.

@iMichka iMichka changed the title bup: use Python3, update vendored dependencies bup: use system Python, update vendored dependencies Dec 8, 2019
@iMichka
Copy link
Member Author

iMichka commented Dec 8, 2019

Let's go with system python then.

@iMichka iMichka closed this in 233dcae Dec 10, 2019
@iMichka iMichka deleted the bup branch December 10, 2019 19:59
@lock lock bot added the outdated PR was locked due to age label Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants