Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Resolve issue with Patient Labs tests #2356

Closed
blestab opened this issue Sep 1, 2020 · 3 comments
Closed

Resolve issue with Patient Labs tests #2356

blestab opened this issue Sep 1, 2020 · 3 comments
Labels
🐛bug issue/pull request that documents/fixes a bug duplicate indicates that an issue/pull request is a duplicate of another issue/pull request LOE - unkown indicates that the level of effort to complete issue is unknown (likely more research is needed)
Milestone

Comments

@blestab
Copy link
Contributor

blestab commented Sep 1, 2020

🐛 Bug Report

When running all tests, notice the warning just after the AddDiagnosisModal test pass confirmation. There is a warning that references Labs.

To Reproduce

Run all tests.
Notice the warning about use of act() and a stack trace just after the AddDiagnosisModal test passed confirmation.

image

Expected behavior

We should not get errors or warnings when tests pass.

Your Environment

  • node version: 10
  • fastify version: >=1.0.0
  • os: Windows 10
  • any other relevant information
@blestab blestab added 🐛bug issue/pull request that documents/fixes a bug LOE - unkown indicates that the level of effort to complete issue is unknown (likely more research is needed) labels Sep 1, 2020
@blestab blestab added this to the v2.0 milestone Sep 1, 2020
@blestab blestab changed the title Resolve issue with AddDiagnosisModal test Resolve issue with Labs test Sep 1, 2020
@blestab blestab changed the title Resolve issue with Labs test Resolve issue with Patient Labs tests Sep 1, 2020
@Tomastomaslol
Copy link
Contributor

Hi @blestab

I believe there already has been an issue raised for this and #2357 at #2287.

I tried to solve it but got stuck while trying to fix one of the tests: #2287 (comment).

if someone else would like to take another look at this I'm happy to provide whatever support I can 🙂

@blestab
Copy link
Contributor Author

blestab commented Sep 1, 2020

Thanks @Tomastomaslol, i did not realise there was another issue already open for this 👍🏾

@blestab blestab added the duplicate indicates that an issue/pull request is a duplicate of another issue/pull request label Sep 1, 2020
@blestab
Copy link
Contributor Author

blestab commented Sep 1, 2020

This is a duplicate of #2287

@blestab blestab closed this as completed Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛bug issue/pull request that documents/fixes a bug duplicate indicates that an issue/pull request is a duplicate of another issue/pull request LOE - unkown indicates that the level of effort to complete issue is unknown (likely more research is needed)
Projects
None yet
Development

No branches or pull requests

2 participants