Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"To preview theme, visit: " should be URL encoded #596

Closed
brycekirk opened this issue Nov 10, 2021 · 0 comments · Fixed by #599
Closed

"To preview theme, visit: " should be URL encoded #596

brycekirk opened this issue Nov 10, 2021 · 0 comments · Fixed by #599

Comments

@brycekirk
Copy link

Description

The preview theme link that Hubspot generates fails if the theme name has a space in it since it isn't URL encoded.

Steps to reproduce

hs watch a theme that isn't the published one and a preview link appears: https://app.hubspot.com/theme-previewer/{account number}/edit/{theme name}

Expected behavior

The theme name should be URL encoded, ie spaces converted to %20, etc,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant