Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add FA icons to page_links #1234

Closed
jpawlowski opened this issue Jul 27, 2019 · 2 comments
Closed

Allow to add FA icons to page_links #1234

jpawlowski opened this issue Jul 27, 2019 · 2 comments

Comments

@jpawlowski
Copy link
Contributor

I would love to see that I could define icons for any button that is processed in page_links.html.

Today I need to make a copy of that file to add icons by myself which might not be as elegant as it could be.

Guess I am not the only person that would be interested to make the content more obvious to distinguish besides the text labels. :-)

@gcushen
Copy link
Collaborator

gcushen commented Jul 27, 2019

This is already supported by the links option. By not using the automated linking features, all icons can be set with links. Also refer to #765 and similar issues.

@gcushen gcushen closed this as completed Jul 27, 2019
@jpawlowski
Copy link
Contributor Author

jpawlowski commented Jul 27, 2019

I'd like you considering to reopen this request as links does not work for every use case.
For example, if you link to a project page using the project: YAML tree, the project page does not get any icon without modifying page_links.html. It would be the same situation for other content types (e.g. slides).

Also, do you consider url_* to be deprecated because links was introduced? If that was the case, I suggest that the template file for the relevant content types is updated here. Most people (like me) will tend to stick to the url_* defaults as the comment indicates that links: shall only be used for custom links where there is no pre-defined content type available from the given list below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants