Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mawranth's Hairs Mismatches #2404

Closed
Systemathic opened this issue Jun 9, 2024 · 0 comments · Fixed by #2405
Closed

Mawranth's Hairs Mismatches #2404

Systemathic opened this issue Jun 9, 2024 · 0 comments · Fixed by #2405

Comments

@Systemathic
Copy link

Hi! In the latest version of MSX+, Mawranths's hairs ( #2372 ) have some mismatches in their ID's within:

       {
          "id": "overlay_female_mutation_beaded_var_black",
          "fg": 241
        },
        {
          "id": "overlay_female_mutation_beaded_var_blond",
          "fg": 242
        },
        {
          "id": "overlay_female_mutation_beaded_var_blue",
          "fg": 243
        },
        {
          "id": "overlay_female_mutation_beaded_var_brown",
          "fg": 244
        },
        {
          "id": "overlay_female_mutation_beaded_var_green",
          "fg": 245
        },
        {
          "id": "overlay_female_mutation_beaded_var_pink",
          "fg": 246
        },
        {
          "id": "overlay_female_mutation_beaded_var_red",
          "fg": 247
        },

This happens due to the above hairs' mutations file, in which, their ID's actually has "hair" in it.
So it should look like:

       {
          "id": "overlay_female_mutation_hair_beaded_var_black",
          "fg": 241
        },
        {
          "id": "overlay_female_mutation_hair_beaded_var_blond",
          "fg": 242
        },
        {
          "id": "overlay_female_mutation_hair_beaded_var_blue",
          "fg": 243
        },
        {
          "id": "overlay_female_mutation_hair_beaded_var_brown",
          "fg": 244
        },
        {
          "id": "overlay_female_mutation_hair_beaded_var_green",
          "fg": 245
        },
        {
          "id": "overlay_female_mutation_hair_beaded_var_pink",
          "fg": 246
        },
        {
          "id": "overlay_female_mutation_hair_beaded_var_red",
          "fg": 247
        },

I changed the files, tested and it worked. (I would love to make these modifications to the repo myself, but github is not my forte, sadly.)

Before:
240609_15h21m32s_screenshot
After:
240609_15h20m18s_screenshot

There may be more mismatches. (Excuse my english; not native language.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant