-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Golang version to 1.17 #242
Comments
Is it a possibility to wait with this update till 1.18 released? |
We could do that or just merge the PR I have and open a new ticket to add 1.18 to our testing matrix, etc |
I'm with @vmatyusGitHub on this one. As of today golang has two stable version 1.17 and 1.6 and 1.18 is still marked as unstable: https://go.dev/dl/ Merging the PR makes sdk not compatible with 1.16, so we'll essentially only support 1.17
I'd prefer us to sit on the merging this PR till 1.18 goes stable, so we are on minimal supported version, not on maximum one. |
Sound good, let's wait until the release of 1.18. |
1.18 release now expected this month: https://tip.golang.org/doc/go1.18 |
@vmatyusGitHub @eiri The |
d) Set But I personally vote for b), after the lint correction published it will work fine, it will be fixed approximately in 2-4 weeks. 🤞 Can we wait that much? |
I'm fine with holding off for a couple weeks until it's fixed. I'm also fine with merging what we have (just 1.17) and then adding in 1.18 once it's fixed. |
Agree. Let's keep 1.16 and 1.17 for now and update the mod to 1.17. |
Ok I'd be fine with that. @eiri @mojito317 wdyt? |
I think we can't bump mod to 1.17 and keep 1.16 at the same time |
@eiri @mojito317 PR is now green after updating golang linter to latest version: #245 |
Is your feature request related to a problem? Please describe.
No, update of oldest supported version of Golang.
Describe the solution you'd like
Update to Golang 1.17
Describe alternatives you've considered
N/A
Additional context
1.18 will be released in Feb after which 1.16 will no longer be supported.
The text was updated successfully, but these errors were encountered: