Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golang version to 1.17 #242

Closed
ricellis opened this issue Feb 2, 2022 · 12 comments · Fixed by #245
Closed

Update Golang version to 1.17 #242

ricellis opened this issue Feb 2, 2022 · 12 comments · Fixed by #245
Assignees

Comments

@ricellis
Copy link
Member

ricellis commented Feb 2, 2022

Is your feature request related to a problem? Please describe.

No, update of oldest supported version of Golang.

Describe the solution you'd like

Update to Golang 1.17

Describe alternatives you've considered

N/A

Additional context

1.18 will be released in Feb after which 1.16 will no longer be supported.

@emlaver emlaver self-assigned this Feb 3, 2022
@vmatyus
Copy link
Contributor

vmatyus commented Feb 4, 2022

Is it a possibility to wait with this update till 1.18 released?

@emlaver
Copy link
Contributor

emlaver commented Feb 4, 2022

We could do that or just merge the PR I have and open a new ticket to add 1.18 to our testing matrix, etc

@eiri
Copy link
Member

eiri commented Feb 7, 2022

I'm with @vmatyusGitHub on this one. As of today golang has two stable version 1.17 and 1.6 and 1.18 is still marked as unstable: https://go.dev/dl/

Merging the PR makes sdk not compatible with 1.16, so we'll essentially only support 1.17

…/github.com/IBM/cloudant-go-sdk on  242-update-golang [?] $ go mod tidy
go mod tidy: go.mod file indicates go 1.17, but maximum supported version is 1.16

I'd prefer us to sit on the merging this PR till 1.18 goes stable, so we are on minimal supported version, not on maximum one.

@emlaver
Copy link
Contributor

emlaver commented Feb 7, 2022

Sound good, let's wait until the release of 1.18.

@emlaver
Copy link
Contributor

emlaver commented Mar 15, 2022

1.18 release now expected this month: https://tip.golang.org/doc/go1.18

@emlaver
Copy link
Contributor

emlaver commented Mar 16, 2022

@vmatyusGitHub @eiri The golangci-lint linter currently does not support 1.18. Issue to track: golangci/golangci-lint#2649
Some options:
a) run 1.18 in travis without the linter (probably not recommended)
b) wait until the issue is fixed
c) merge current PR with just 1.17 and open a new issue for 1.18

@vmatyus
Copy link
Contributor

vmatyus commented Mar 16, 2022

d) Set typecheck package as disabled till compatibility got not corrected.

But I personally vote for b), after the lint correction published it will work fine, it will be fixed approximately in 2-4 weeks. 🤞 Can we wait that much?

@emlaver
Copy link
Contributor

emlaver commented Mar 16, 2022

I'm fine with holding off for a couple weeks until it's fixed. I'm also fine with merging what we have (just 1.17) and then adding in 1.18 once it's fixed.
@mojito317 FYI

@vmatyus
Copy link
Contributor

vmatyus commented Mar 18, 2022

I'm also fine with merging what we have (just 1.17) and then adding in 1.18 once it's fixed.

Agree. Let's keep 1.16 and 1.17 for now and update the mod to 1.17.
After create an issue to update to 1.18 after the lint have a released fix. Even the PR can be prepared and can be moved under the Blocked coloumn.

@emlaver
Copy link
Contributor

emlaver commented Mar 18, 2022

Ok I'd be fine with that. @eiri @mojito317 wdyt?

@eiri
Copy link
Member

eiri commented Mar 18, 2022

I think we can't bump mod to 1.17 and keep 1.16 at the same time go mod tidy will just block install on 1.16.

@emlaver
Copy link
Contributor

emlaver commented Mar 24, 2022

@eiri @mojito317 PR is now green after updating golang linter to latest version: #245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants