Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FedAvgLocalTrainingHandler forgot to update for pretrain/posttrain evaluation #76

Open
Hugomiralles opened this issue Aug 23, 2021 · 1 comment

Comments

@Hugomiralles
Copy link

In class FedAvgLocalTrainingHandler in script party/training/fedavg_local_training_handler.py, I think there is a mistake. The two methods get_train_metrics_pre and get_train_metrics_post (of the inherited class LocalTrainingHandler) are not applied, resulting in no local metrics for the aggregated method FedAvg.
Sorry for submitting an issue, I don't know how to make a pull request with whl files...

@Yi-Zoey
Copy link
Member

Yi-Zoey commented Aug 25, 2021

Hi @Hugomiralles thanks for pointing out the bug. We are aware of it and working on improving the performance of the experimental manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants