Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress removed #87

Merged
merged 6 commits into from
Mar 15, 2022
Merged

ingress removed #87

merged 6 commits into from
Mar 15, 2022

Conversation

manojn97
Copy link

Pull Request Review

Checklist

  • Issue: Ingress removal #86
  • List of related PRs. : None
  • Project builds without any errors.
  • Unit Tests updated (or created where needed) and all pass.
  • You have ran manual functional “smoke” test (does product as a whole still work?).
  • User Story meets the acceptance criteria - and passes. acceptance criteria should be understood at outset.
  • There is a PR for update of internal documentation for the affected Project(s) - README etc.
  • Description of the changes: Ingress removal #86

hhellyer
hhellyer previously approved these changes Mar 11, 2022
View reviewed changes
dvaccarosenna
dvaccarosenna requested changes Mar 11, 2022
View reviewed changes
Copy link
Member

@dvaccarosenna dvaccarosenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think there's been a misunderstanding on the required change here.

We need to remove the "Ingress" that is deployed as part of the Kubernetes driver helm chart and update any documentation to reflect that this is no longer part of the deployment.

We do not need to remove all uses of the word "Ingress". An Ingress resource is a valid Kubernetes resource which can deployed by this driver during an intent.

docs/reference/associated-topology.md Outdated Show resolved Hide resolved
docs/user-guide/building-a-resource.md Outdated Show resolved Hide resolved
docs/user-guide/ready-checks.md Outdated Show resolved Hide resolved
docs/user-guide/ready-checks.md Outdated Show resolved Hide resolved
docs/user-guide/ready-checks.md Outdated Show resolved Hide resolved
tests/unit/kubeobjects/example_object_config_files/multidoc_dots_at_end.yaml Outdated Show resolved Hide resolved
tests/unit/kubeobjects/example_object_config_files/multidoc_emptydoc_in_middle.yaml Outdated Show resolved Hide resolved
tests/unit/kubeobjects/example_object_config_files/multidoc_separator_at_end.yaml Outdated Show resolved Hide resolved
tests/unit/kubeobjects/example_object_config_files/multidoc_separator_at_start.yaml Outdated Show resolved Hide resolved
tests/unit/kubeobjects/test_config_doc.py Outdated Show resolved Hide resolved
@manojn97 manojn97 closed this Mar 14, 2022
@manojn97 manojn97 reopened this Mar 14, 2022
@manojn94
Revert "remove ingress"
9c53123 
This reverts commit f2d235d.
hhellyer
hhellyer approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@hhellyer hhellyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as these changes look smaller and reasonable but @dvaccarosenna is better placed to say whether they now meet the requirements.

@lokanalla lokanalla merged commit ad77eff into IBM:develop Mar 15, 2022
@manojn97 manojn97 mentioned this pull request Mar 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvaccarosenna dvaccarosenna dvaccarosenna approved these changes

@hhellyer hhellyer hhellyer approved these changes

@owen-lynch-ibm owen-lynch-ibm Awaiting requested review from owen-lynch-ibm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@manojn97 @hhellyer @dvaccarosenna @lokanalla @manojn94