Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test coverage for ibmcloud be using GH self hosted runners #94

Open
aavarghese opened this issue Aug 6, 2024 · 3 comments · May be fixed by #193
Open

test: add test coverage for ibmcloud be using GH self hosted runners #94

aavarghese opened this issue Aug 6, 2024 · 3 comments · May be fixed by #193
Labels

Comments

@aavarghese
Copy link
Member

No description provided.

@starpit
Copy link
Member

starpit commented Aug 6, 2024

This would be nice. I'm not sure how we avoid leaking secrets? Any self-hosted runner would need an apikey for ibm cloud? We could provision the runner to have a security group that blocks access to any outbound connection other than the ibm cloud api servers. This would protect tcp-based escape. But... the user code could still just log the secret to the console? If this were a github action-provided secret, their log viewers would hopefully be smart enough to redact the secrets from any displayed logs. But... if this is just some random string that github doesn't know about...?

@starpit starpit added the test label Aug 6, 2024
@aavarghese
Copy link
Member Author

If a secret is set via input or env var in the GH action workflow, GH should know what it is and redact it in the logs ref self- hosted runners may also behave the same, and we will need a minimum access apikey for it plus additional security like no outbound sec group rules, as you mentioned

@starpit
Copy link
Member

starpit commented Aug 6, 2024

is there a way for us (as non-owners of org IBM) to configure env vars?

@aavarghese aavarghese linked a pull request Sep 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants