feat(CP4D Authentication): add ssl verification for self-signed certificates #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
to elaborate a bit more on this, these changes are for the Authentication step (getting a token). During regular SDK calls we can still pass |
padamstx
requested changes
Aug 1, 2022
…ficates Signed-off-by: Luc Exposito <[email protected]> Signed-off-by: LExposito <[email protected]>
Signed-off-by: LExposito <[email protected]>
|
Docstrings are updated ! |
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Aug 1, 2022
# [3.16.0](v3.15.3...v3.16.0) (2022-08-01) ### Features * **CP4D Authentication:** add ssl verification for self-signed certificates ([#147](#147)) ([a16685d](a16685d))
|
🎉 This PR is included in version 3.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modifications allow the user to have a self-signed certificate in the SSL verification process when authenticating to an STT instance on CP4D.
The
verifyattribute is used by the requests python module to indicate the path to a custom CA Bundle (resquests documentation).With these changes, it wont be necessary to disable ssl verification anymore when using a self-signed certificate with STT on CP4D.