-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MCSPAuthenticator): add new authenticator for Multi-Cloud Saas Platform #181
Conversation
167c676
to
2bc374f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
…latform This commit introduces the new MCSPAuthenticator that can be used to exchange an apikey for an MCSP access token using the Multi-Cloud Saas Platform authentication token server's 'POST /siusermgr/api/1.0/apikeys/token' operation. Signed-off-by: Phil Adams <[email protected]>
2bc374f
to
08e0f02
Compare
One question that's slightly related to this. Currently, when the |
I think that's an intentional priority we built into the code based on which authenticators are most common in practice and I think the other cores will do the same thing (though I could be wrong on that). It is worth considering how good of an experience that is because implicit behavior can often be a source of confusion for users but if we're doing this in every core, altering the behavior would be a breaking change as users could be relying on this implicit behavior. |
correct, this is intentional, and we have the same logic in the other cores as well the net result is... to use IAM, just configure the APIKEY config property at a minimum; to use one of the other authenticators that support APIKEY, you'd need to also set AUTH_TYPE to indicate which one to use. |
Okay thanks, it makes sense! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
# [3.18.0](v3.17.3...v3.18.0) (2023-11-15) ### Features * **MCSPAuthenticator:** add new authenticator for Multi-Cloud Saas Platform ([#181](#181)) ([1be97e5](1be97e5))
🎉 This PR is included in version 3.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This commit introduces the new MCSPAuthenticator that can be used to exchange an apikey for an MCSP access token using the Multi-Cloud Saas Platform authentication token server's 'POST /siusermgr/api/1.0/apikeys/token' operation.