Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send user-agent header with auth token requests #191

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Apr 16, 2024

This commit updates our various request-based authenticators so that the User-Agent header is included with each outbound token request. The value of the User-Agent header will be of the form ibm-python-sdk-core/<authenticator-type>-<core-version> <os-info>.

@padamstx padamstx self-assigned this Apr 16, 2024
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

ibm_cloud_sdk_core/api_exception.py Show resolved Hide resolved
ibm_cloud_sdk_core/private_helpers.py Outdated Show resolved Hide resolved
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ibm_cloud_sdk_core/private_helpers.py Show resolved Hide resolved
test/test_iam_token_manager.py Show resolved Hide resolved
This commit updates our various request-based authenticators
so that the User-Agent header is included with each outbound
token request. The value of the User-Agent header will be
of the form "ibm-python-sdk-core/<authenticator-type>-<core-version> <os-info>".

Signed-off-by: Phil Adams <[email protected]>
@padamstx padamstx merged commit 37014b5 into main Apr 17, 2024
4 checks passed
@padamstx padamstx deleted the auth-user-agent branch April 17, 2024 19:40
ibm-devx-sdk pushed a commit that referenced this pull request Apr 17, 2024
# [3.20.0](v3.19.2...v3.20.0) (2024-04-17)

### Features

* send user-agent header with auth token requests ([#191](#191)) ([37014b5](37014b5))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 3.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants