fix: specify the maximum version of requests to avoid regression
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Version `2.23.3` of the `requests` package broke our custom `SSLHTTPAdapter`. This commit defines the maximum version of that package, to make sure it will continue working without an issue. Note that, this is a short term solution only. For more details see this issue: psf/requests#6730 Signed-off-by: Norbert Biczo <[email protected]>
pyrooka
force-pushed
the
nb/fix-requests-regression
branch
from
e5e87db
to
f2be943
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jun 3, 2024
## [3.20.1](v3.20.0...v3.20.1) (2024-06-03) ### Bug Fixes * specify the maximum version of `requests` to avoid regression ([#194](#194)) ([f4ac0d1](f4ac0d1))
|
🎉 This PR is included in version 3.20.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
2.23.3of therequestspackage broke our customSSLHTTPAdapter. This commit defines the maximum version of that package, to make sure it will continue working without an issue. Note that, this is a short term solution only. For more details see this issue: psf/requests#6730