Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ListAcls method does not return the AclResourcePatternType field #1451

Closed
symaras opened this issue Aug 6, 2019 · 3 comments
Closed

The ListAcls method does not return the AclResourcePatternType field #1451

symaras opened this issue Aug 6, 2019 · 3 comments

Comments

@symaras
Copy link
Contributor

symaras commented Aug 6, 2019 •
edited
Loading

Versions

Sarama Version: 1.23.0
Kafka Version: 2.1.0
Go Version: 1.11.1

Problem Description

The ListAcls method of the ClusterAdmin interface does not consider the version of the config. Thus, it creates a DescribeAclsRequest struct with no version defined and this defaults to V0_11_0_0, which in turn causes the method to not return the AclResourcePatternType field.
@symaras symaras mentioned this issue Aug 6, 2019
Merged
@varun06
Copy link
Contributor

varun06 commented Aug 7, 2019

Hey @symaras

would you please do a PR for the change?

@symaras
Copy link
Contributor Author

symaras commented Aug 7, 2019

Hi @varun06, here it is: #1452

@symaras
Copy link
Contributor Author

symaras commented Aug 16, 2019

PR merged, closing issue.

@symaras symaras closed this as completed Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@varun06 @symaras