Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acception context for sync produce message #1849

Closed
longquanzheng opened this issue Dec 6, 2020 · 3 comments
Closed

Acception context for sync produce message #1849

longquanzheng opened this issue Dec 6, 2020 · 3 comments
Labels
needs-investigation Issues that require followup from maintainers stale Issues and pull requests without any recent activity v2

Comments

@longquanzheng
Copy link

Problem Description

https://github.com/Shopify/sarama/blob/0616f68815691527d3b6ab4d95a2881e09400fe3/sync_producer.go#L20

Please allow passing in context.Context
https://blog.golang.org/context

It's important for error handling.
@ghost

This comment was marked as outdated.

Sign in to view
@ghost ghost added the stale Issues and pull requests without any recent activity label Mar 16, 2021
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2023
@dnwe dnwe added v2 and removed stale Issues and pull requests without any recent activity labels Aug 25, 2023
@dnwe dnwe reopened this Aug 29, 2023
@dnwe dnwe added the needs-investigation Issues that require followup from maintainers label Aug 29, 2023
@github-actions GitHub Actions
Copy link

Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur.
Please check if the main branch has already resolved the issue since it was raised. If you believe the issue is still valid and you would like input from the maintainers then please comment to ask for it to be reviewed.

@github-actions github-actions bot added the stale Issues and pull requests without any recent activity label Nov 27, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2023
@advdv advdv mentioned this issue Jun 28, 2024
Open
@r-novel
Copy link

r-novel commented Jul 5, 2024

@dnwe Hello, Dominic. Do you have any updates about your investigation? I think support context.Context in produce methods is very actual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-investigation Issues that require followup from maintainers stale Issues and pull requests without any recent activity v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@longquanzheng @r-novel @dnwe