You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Per discussion with @jmcameron, based on discussions in #7382.
Note this doesn't really affect anyone but the tests, correctness of the tests, and the MD of Vanga who travels frequently.
Currently, the BHIMA test database does not control for varying timezones, causing test failures if the timezone of the host machine is not set to the timezone of the test dataset. There are a couple of potential sources of error:
The test dataset was created at multiple different times, often with reference to the timezone (UTC+1 or UTC+2). These are often embedded in the new Date() or in the data.sql file. Because these are hard-coded, they will never change from these timezones, no matter what time the server is running in.
The test server + client will run in the timezone of the user's machine. This means that filters such as "transactions created today" may be interpreted differently based on the timezone the user's machine is in. For example, if a transaction is made at 3AM in Vanga, is it still considered "Today" on the previous day in New Orleans. The test results will give two different results for two different people running the tests across the world.
In light of all this, we should come up with some kind of solution to ensure that the test results are reproducible everywhere. One idea is to only store test data in reference to UTC time, and then run all the tests with the server and client in the UTC timezone. Are there others?
The text was updated successfully, but these errors were encountered:
Per discussion with @jmcameron, based on discussions in #7382.
Note this doesn't really affect anyone but the tests, correctness of the tests, and the MD of Vanga who travels frequently.
Currently, the BHIMA test database does not control for varying timezones, causing test failures if the timezone of the host machine is not set to the timezone of the test dataset. There are a couple of potential sources of error:
In light of all this, we should come up with some kind of solution to ensure that the test results are reproducible everywhere. One idea is to only store test data in reference to UTC time, and then run all the tests with the server and client in the UTC timezone. Are there others?
The text was updated successfully, but these errors were encountered: