Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for managing ontologies with merged/base file imports #514

Closed
shawntanzk opened this issue Jan 13, 2022 · 5 comments · Fixed by #516
Closed

Documentation for managing ontologies with merged/base file imports #514

shawntanzk opened this issue Jan 13, 2022 · 5 comments · Fixed by #516
Assignees
Milestone

Comments

@shawntanzk
Copy link
Contributor

We need to write up documentation on how to manage ontologies that have switched to base file imports such as CL and PATO.
Suggest that we edit UpdateImports section in https://github.com/INCATools/ontology-development-kit/edit/master/template/_dynamic_files.jinja2 to include a subsection on base file imports.

We further need documentation on how to switch ontologies to base file imports but that can come later

@shawntanzk shawntanzk self-assigned this Jan 13, 2022
@shawntanzk
Copy link
Contributor Author

Related to obophenotype/cell-ontology#1404

@matentzn
Copy link
Contributor

I would not recommend this strategy anymore, especially for people that are able to run odk: the main strategy should be to add the id, as we previously did to the imports/cl_terms.txt file, then refresh the import. However, documenting as you have done is good, as editors with no ability to run odk may need to do it using the Protege-based strategy.

@shawntanzk
Copy link
Contributor Author

oh I thought that the individual import files are not used anymore - so basically if we add it to terms then refresh merged it will work?

@shawntanzk shawntanzk reopened this Jan 17, 2022
@matentzn
Copy link
Contributor

Yes, if everything goes as planned, this here:
https://github.com/INCATools/ontology-development-kit/blob/master/template/src/ontology/Makefile.jinja2#L273

Should merge all the term files into one big heap and then use that to extract the module.

@shawntanzk
Copy link
Contributor Author

Thanks @matentzn - I'll update the docs accordingly

@matentzn matentzn added this to the 1.2.33 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants