Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain dtypes from odml-terminologies are missing #121

Open
fabianschlebusch opened this issue Jan 21, 2021 · 1 comment
Open

Certain dtypes from odml-terminologies are missing #121

fabianschlebusch opened this issue Jan 21, 2021 · 1 comment
Labels

Comments

@fabianschlebusch
Copy link
Contributor

When using odml-terminologies, e.g., https://github.com/G-Node/odml-terminologies/blob/master/v1.1/dataset/dataset.xml there are dtypes which raise an exception during consistency_check() in odml_tables.py

For example, from the dataset terminology, the synonym "URL" for "url", but also "2-tuple" from the pulse stimulus are missing. Potentially there are even more dtypes missing. Can I safely add "2-tuples" to valid_dtypes and "URL" as synonym for "url"?

@JuliaSprenger
Copy link
Collaborator

Hi @fabianschlebusch,
thanks for the note, I get the same error for "URL" with the dataset.xml. For "URL" this should be straight forward by adding it to the synonyms. For 2-tuples this might require some more adjustments as there's no equivalent implemented yet.

Related to that it might in general be a good idea to add a unit test based on the odml-terminologies files at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants