Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template for Neighborhoods pages to remove MTF top logo #147

Open
MirandaEcho opened this issue Feb 4, 2020 · 11 comments
Open

Update template for Neighborhoods pages to remove MTF top logo #147

MirandaEcho opened this issue Feb 4, 2020 · 11 comments
Assignees

Comments

@MirandaEcho
Copy link
Collaborator

No description provided.

@MirandaEcho MirandaEcho added this to the CITY-009 - SoW milestone Feb 4, 2020
@benlk
Copy link
Collaborator

benlk commented Feb 4, 2020

Example: https://citylimits.org/neighborhoods/east-harlem/

Present:

Screen Shot 2020-02-04 at 18 05 50

To remove the image:

<a href="/series/zonein/"><img src="<?php echo get_stylesheet_directory_uri(); ?>/img/mapping-the-future-logo.png" alt="Mapping The Future Project Logo" width="100%" /></a>

Removing the image from header-rezone.php will affect:

Should this change only affect the Neighborhoods pages, or all pages currently using this header?

After removing the image:

Screen Shot 2020-02-04 at 18 06 24

Are there any other changes that need to be made to this area?

@MirandaEcho
Copy link
Collaborator Author

@benlk - its an old logo, so lets remove it from anywhere its used in the header

@MirandaEcho
Copy link
Collaborator Author

What would it take to add the top portion (name, photo, blurb, icon) from this page: https://citylimits.org/series/futuremap/ to the Neighborhoods template as well?

@joshdarby
Copy link

What would it take to add the top portion (name, photo, blurb, icon) from this page: https://citylimits.org/series/futuremap/ to the Neighborhoods template as well?

@MirandaEcho Do you want an estimate for that or do you want me to try and cram it in to the remaining 57m this issue has?

@joshdarby
Copy link

Update: tried adding the section to the old template while using the existing CSS. Most of it worked, but we'd need to modify some parts. I'd think we could get this done in under an hour and a half (including review).

@joshdarby
Copy link

Another update:

The only modification I had to make was moving #series-header and .series-banner out of the parent .cftl-tax-landing-template-series-landing-special-projects-php styling

screencapture-citylimits-test-series-futuremap-2020-02-19-15_31_34-1

The only issue I can see is that from 800px to 600px, the header area overlaps the rezone-overview area

Screen Shot 2020-02-19 at 3 34 00 PM

@MirandaEcho
Copy link
Collaborator Author

@joshdarby - is this done then and on staging?

@joshdarby
Copy link

@MirandaEcho No, I was never told whether or not the estimate I gave was approved and that I could finish up the work on it

@MirandaEcho
Copy link
Collaborator Author

I wasn't sure if that last update meant it was done or not, sorry! Please proceed. Thanks!

@joshdarby
Copy link

@MirandaEcho This is now deployed to staging.

@MirandaEcho
Copy link
Collaborator Author

@joshdarby lets hardcode this as the featured image in the top (next to the page title) while keeping the neighborhood featured image below it:

Mapping the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants