Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay headline on featured image. #39

Open
MirandaEcho opened this issue Mar 24, 2020 · 10 comments
Open

Overlay headline on featured image. #39

MirandaEcho opened this issue Mar 24, 2020 · 10 comments
Assignees

Comments

@MirandaEcho
Copy link

Change styling to have article headline overlaid on the featured image, including adding a background to either the headline or an overlay on the image to ensure headline is always visible.

Overlay or headline background - which is easiest?

@joshdarby joshdarby self-assigned this Mar 25, 2020
@joshdarby
Copy link

Change styling to have article headline overlaid on the featured image, including adding a background to either the headline or an overlay on the image to ensure headline is always visible.

Where is this supposed to be done? Homepage, article pages, everywhere?

@joshdarby
Copy link

"Let's do the secondary headline after the photo w/ the byline after that. Make sense? Thanks again!"

So order should be:

  • Headline + photo overlay
  • Subtitle/secondary headline
  • Byline

@joshdarby
Copy link

@MirandaEcho How do we want to handle this for mobile?

We can:

  • Not overlay it on mobile
  • Do what we did for Workday and put the title below the image like so
    Screen Shot 2020-03-25 at 12 58 41 PM
  • Still overlay the text, just make it smaller so it fits inside of the image container

@joshdarby
Copy link

Also, do we want to make the image full-width on desktop like we did for Workday?

Here's how it is at the current size:
screencapture-mwcir-test-2017-07-02-migrant-farm-workers-file-class-action-lawsuit-against-monsanto-2020-03-25-13_00_14

@MirandaEcho
Copy link
Author

@joshdarby:

  1. Is it possible to do the headline on the lower left of the photo vs centered and have a boxed background?
  • I'm guessing this will exceed available time left, but let me know if that's not the case.
  1. Headline below image on mobile is fine
  2. Keep headline photo size as is.

@joshdarby
Copy link

Is it possible to do the headline on the lower left of the photo vs centered and have a boxed background?
I'm guessing this will exceed available time left, but let me know if that's not the case.

@MirandaEcho Yes, it's possible, but would add probably another 30m-1h of time to this.

@joshdarby
Copy link

@MirandaEcho Is this along the lines of what they're hoping for?

Screen Shot 2020-04-08 at 1 58 05 PM

@MirandaEcho
Copy link
Author

Will send to Pamela and have her take a look. Thanks!

@joshdarby
Copy link

@kaylima @MirandaEcho What should the styling look like for a post with no featured image?

Here's how it currently looks with this implementation:
Screen Shot 2020-04-13 at 12 26 09 PM

Should we keep it like this or make it look like their current titles? Example: https://investigatemidwest.org/2020/04/10/numerous-nursing-homes-cited-for-problems-in-infection-prevention-programs/

@joshdarby
Copy link

This has been deployed to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants