Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer is flushed🚽 after every single Redis query #10100

Open
Al2Klimov opened this issue Jul 23, 2024 · 0 comments
Open

Buffer is flushed🚽 after every single Redis query #10100

Al2Klimov opened this issue Jul 23, 2024 · 0 comments
Labels
area/icingadb New backend good first issue Good for newcomers

Comments

@Al2Klimov
Copy link
Member

Describe the bug

Even given a bulk of queries, RedisConnection#WriteItem() loops them calling WriteOne().
The latter calls WriteRESP() and async_flush().

Expected behavior

Write everything queued, flush once.

Your Environment

c5c7925

Additional context

While more async I/O may even reduce mutex contention, this is not what our buffered streams are for.

@Al2Klimov Al2Klimov added area/icingadb New backend good first issue Good for newcomers labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/icingadb New backend good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant