Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for new Feature make comments collapsible #4515

Closed
tomabg opened this issue Aug 25, 2021 · 3 comments · Fixed by #4548
Closed

Proposal for new Feature make comments collapsible #4515

tomabg opened this issue Aug 25, 2021 · 3 comments · Fixed by #4548
Assignees
Labels
area/monitoring Affects the monitoring module area/ui Affects the user interface bug Something isn't working
Milestone

Comments

@tomabg
Copy link

tomabg commented Aug 25, 2021

Hi,

i made an integration of icinga into a monitoring system which also includes regular status updates and so on.
The problem i have is hat comments after time may very long (1000 + lines or more).

It would be a usefull feature if comments can be collabsed to a configuratble number of lines.
Maybe 25 Lines are default and it should be overwriteable in Users Preferences.

This would be usefull in service View and comments view

Maybe a usefull feature for Icingaweb2?

@nilmerg
Copy link
Member

nilmerg commented Aug 25, 2021

Hi,

I have to differentiate here:

  • Host/Service detail lists comments, if they'll contain images or large chunks of text they're still shown in their entirety
  • The same applies to the comment overview (list)

Comments in these places don't need to be shown in their entirety. The full comment (comment detail) though should be a single click away.

The comment detail on the other hand already shows the full comment and I see no reason why it should be collapsed there as the place there is already reserved for the comment.

So no, making comments collapsible here isn't the right solution. We should instead limit the shown comment to e.g. two lines and only reveal the full comment by clicking on it.

This could look like this: (Image taken from Icinga DB Web)

Screenshot from 2021-08-25 15-45-13

Hence I'll mark this as bug, will also help to get this resolved more quickly 😉

@nilmerg nilmerg added area/monitoring Affects the monitoring module area/ui Affects the user interface bug Something isn't working labels Aug 25, 2021
@tomabg
Copy link
Author

tomabg commented Aug 26, 2021

Hi,

for the comment list.
Imagine you have some very long comments(maybe 2000 lines) and you want to check for new comments in comment list.
Normally you are not interested in the whole 2000 lines comment but however in some cases it maybe interesting.

Therefore at least in my case it also makes sence to limit the number of lines per comment in comment list also.

BR
Thomas

@tomabg
Copy link
Author

tomabg commented Aug 26, 2021

collapse

probably realize this in the same way like for long Performance data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Affects the monitoring module area/ui Affects the user interface bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants