Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid:Excel Style Filtering - selecting more than two text filters and their visualisation #14449

Closed
AnjiManova opened this issue Jun 28, 2024 · 1 comment

Comments

@AnjiManova
Copy link

I noticed something else, and we talked with Desi: This is an additional issue that should be logged, but we can create such from this comment here.

When I select one list item, the Text filter is changed to Text filter (1), and "Equal" is selected from the filters.
When I select two list items, the Text filter is changed to Text filter (2), and the "Custom filter" is selected from the filters. However, when I select three items, the Text filter is changed to Text filter (1), and there is no selection in the Text filters. Shouldn't it be showing the "Custom filter" again? This is replicated from the Master, and it is an issue there as well.

Screen.Recording.2024-06-28.at.11.12.37.mov

I believe the logic should be: when two or more items are selected to apply the Custom filter, the filters should be indicated with (n) next to the Text filter.

Something interesting here is that everything looks fine if I select two items and then add more from the Custom filter. After manually adding an additional filter, there is no indication of which items/filters are selected.

Screen.Recording.2024-06-28.at.11.12.58.mov

Originally posted by @AnjiManova in #14328 (comment)

@georgianastasov
Copy link
Contributor

After discussing with @hanastasov, we have confirmed that this is not a bug and does not need fixing. When one or two items are selected, we use individual equality conditions. However, for selections greater than two, the expression tree consolidates these into a single filtering operand with multiple values under an 'IN' condition.

Additionally, the part regarding Text filter(n) should not be fixed. Technically, when the "IN" condition is created, it acts as a single condition even though it checks against a collection of items.

In the dialog where filters are listed, we should avoid making changes too. Including an 'IN' filter along with 'Contains', 'Does not contain', and other filters would require a UI to list all values against which we match (i.e., all selected items in the ESF list). This 'IN' filter is very specific to ESF and does not make sense to be displayed in this dialog, which is why it is not shown there initially.

@georgianastasov georgianastasov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. status: not-a-bug labels Jul 11, 2024
@hanastasov hanastasov removed the ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants