Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single errors in lat and lon break the map #48

Closed
omnomdombomb opened this issue Aug 15, 2023 · 2 comments · Fixed by #54
Closed

Single errors in lat and lon break the map #48

omnomdombomb opened this issue Aug 15, 2023 · 2 comments · Fixed by #54
Assignees
@egrace479
Labels
bug Something isn't working

Comments

@omnomdombomb
Copy link

If the lat or lon values are incorrectly formatted they with be read as integers instead of floats. This breaks the entire map dashboard. Code should be added to ignore these errors.
@egrace479
Copy link
Member

egrace479 commented Aug 15, 2023 •
edited
Loading

If the lat or lon values are incorrectly formatted they with be read as integers instead of floats. This breaks the entire map dashboard. Code should be added to ignore these errors.

Yes, I believe it's problematic when the lat value is outside [-90, 90] or lon is outside [-180, 180]. I can add a check for that while processing the data to remove problematic values. Great catch!

@egrace479 egrace479 self-assigned this Aug 15, 2023
@egrace479 egrace479 added the bug Something isn't working label Aug 15, 2023
@egrace479 egrace479 mentioned this issue Aug 23, 2023
Merged
@egrace479
Copy link
Member

Addressed in PR #50 to the dev branch. Will be implemented in v1.1.0.

@egrace479 egrace479 mentioned this issue Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egrace479 egrace479

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1.1.0 dashboard updates Imageomics/dashboard-prototype
2 participants
@egrace479 @omnomdombomb