Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depricating funding type in favor of a fine grained config #193

Closed
f-gate opened this issue Aug 7, 2023 · 0 comments
Closed

Depricating funding type in favor of a fine grained config #193

f-gate opened this issue Aug 7, 2023 · 0 comments
Labels
Priority | High refactor Refactoring is required

Comments

@f-gate
Copy link
Member

f-gate commented Aug 7, 2023

I have been thinking of how we can deal with all the different paths that a project can take when it comes to disputes, refunds etc and have come up with an abstraction.
At the moment we do it all on FundingType however this is very broad and actually is just a setting on how a project is funding.
This new abstraction allows for a bit more fine grained control as you set a config on a per project basis but requires devs to be a little more careful.
It may also allow for a sdk for other developers that want to use the escrow and milestone system, also they could make use of the fellowship for disputes.

Any feedback appreciated:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=9fd712fef256a43054b21be8dd1d64f1

To be implemented before pallet-dispute.

@f-gate f-gate added refactor Refactoring is required Priority | High labels Aug 7, 2023
@f-gate f-gate mentioned this issue Aug 7, 2023
9 tasks
This was referenced Sep 12, 2023
@f-gate f-gate closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority | High refactor Refactoring is required
Projects
None yet
Development

No branches or pull requests

1 participant