Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check function for correct column/index order #107

Open
3 tasks
konstantinstadler opened this issue May 30, 2023 · 0 comments
Open
3 tasks

check function for correct column/index order #107

konstantinstadler opened this issue May 30, 2023 · 0 comments
Assignees
Labels

Comments

@konstantinstadler
Copy link
Member

dangerous bug in calc_A

it takes the values from the dataframe without ensuring that the order of columns without ensuring the order of columns is correct.
This can lead to hard to find bugs when adding new extensions to a mrio.

Improvements:

  • check if calc_A is the only function where this is a problem
  • investigate if instead of taking .values we could use the dataframes directly. If this is not possible, we need to check for correct order before doing any calculations
  • there should also be some .validate function, which checks for balance and if the order of columns is correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant