Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

column/index name hardcoded as strings - move to constants #121

Open
konstantinstadler opened this issue Sep 6, 2023 · 1 comment
Open

Comments

@konstantinstadler
Copy link
Member

konstantinstadler commented Sep 6, 2023

the column.names / index.names are hardcoded as strings - move to constants.
There are not to many places where this is used, so it should be easy to change.

@konstantinstadler
Copy link
Member Author

there is already a generic_names in constants - this is used in 2 different places:

  1. for giving names to aggregated region/sectors
  2. for checking iosystem and such

Either we separate this or find better naming to make the purpose clear. Currently best choice: remove the aggregation logic (this is quite specific and could just be a parameter) and use the generic_name for column names and such

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant